Migrated NQL workspace to pnpm (PLA-322) - #201
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 9 9
Lines 2074 2074
Branches 428 428
=======================================
Hits 1746 1746
Misses 322 322
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Why
Complete the NQL portion of PLA-322 by moving the workspace from Yarn Classic to the same fail-closed pnpm supply-chain baseline used by Ghost-owned repositories.
This supersedes #200: it includes that PR's privileged install-script blocking while migrating the underlying install to pnpm.
What changed
yarn.lockwith a frozenpnpm-lock.yamlminimumReleaseAge: 4320,strictDepBuilds: true, andblockExoticSubdeps: truesqlite3@6.0.1: truebecause the SQLite test matrix requires its native bindingnx@23.1.1: falsebecause Lerna's task runner does not require Nx's install-time setup--ignore-scriptsin the OIDC-enabled publish job, regardless of ordinary CI's reviewed build approvalsValidation
corepack pnpm install --frozen-lockfilecorepack pnpm lintcorepack pnpm buildcorepack pnpm test(SQLite)corepack pnpm install --frozen-lockfile --prefer-offline --ignore-scriptsnpm publish --dry-run --workspaces(all four packages)actionlintgit diff --check